Strip out Enable/Disable #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a not-so-good laptop, a full test run went from ~90seconds to less than 10. Three independent changes were made: 1 - In TruncateAll, use `delete from` instead of `truncate`. While truncate is faster for large tables, for small tables, it has considerably more overhead (my understanding is that delete just flags the tuple as dead, whereas truncate involves a vacuum-like operation). 2 - In tests, use bcrypt.MinCost instead of bcrypt.DefaultCost 3 - Use a 10 millisecond timeout, instead of 1 second timeout, for TestHookTimeout
This reverts commit c65c136.
inian
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Strips out the /enable and /disable routes on MFA as they are no longer relevant. Whether or not a user has MFA enabled will be determined by whether a user has >= 1 verified factors linked to their account.
Also contains the changes from Karl's PR to speed up tests so that they can be used within the MFA branch
What is the current behavior?
There are /enable and /disable routes which allow a user to toggle whether or not they can use factor related routes
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
We still need to strip out the notion of
MFAEnabledon a user as well as on the DB as well as the user model but that will be done on a follow up PR as it affects most all of the methods and will be huge.The implementation order for refactoring will be:
MFAEnabledand instead check if there is a verified factor for relevant endpoints.