fix: add mfa migrations #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
reviewed
Oct 3, 2022
hf
reviewed
Oct 3, 2022
There was a problem hiding this comment.
You should use the {{ index .Options "Namespace" }} template string instead of auth I think. @kangmingtay made this change to support arbitrary search paths a few weeks ago.
|
Ah yes I forgot about that, thanks for the catch! Let me amend it now |
hf
previously approved these changes
Oct 3, 2022
kangmingtay
approved these changes
Oct 3, 2022
|
🎉 This PR is included in version 2.17.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Merges in the database changes from MFA. Obtained by doing
git checkout -p mfa_v1 <filename>and subsequently taking the session changes and moving it to a separate migration