Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Signup Confirmation Email Link Issue #91

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Fix for Signup Confirmation Email Link Issue #91

merged 2 commits into from
Apr 26, 2021

Conversation

AngeloAnolin
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix for Signup Confirmation Email link on second and subsequent clicks.

What is the current behavior?

Subsequent clicks on confirmation link sent when user signs up results in error User not found.

What is the new behavior?

Descriptive error informing user that Confirmation Token was not found.

Additional context

User will also be redirected back to the application with the error context in the return url.

@AngeloAnolin
Copy link
Contributor Author

AngeloAnolin commented Apr 23, 2021

As @awalias mentioned, the the function needs to redirect back to the application. I reused the current implementation of redirectWithQueryError which is used similarly when recovering account and redirecting.

This also supersedes the original PR # 82 made previously.

@kiwicopple kiwicopple requested a review from awalias April 26, 2021 02:21
@awalias
Copy link
Member

awalias commented Apr 26, 2021

confirmed that it fixes supabase/supabase#504

@awalias awalias merged commit e246acf into supabase:master Apr 26, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.5.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants