fix(ext/ai): Invalid tensor length causing Segmentation Fault #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, CRITICAL
What is the current behavior?
If a
Tensor
received from JS land havesdata.length
not compatible with thedims
then when feeding theSession
a Segmentation Fault: 11 error will be panic!.How to reproduce it:
The tensors is successfully handled by
rust
as wellJsTensor::extract_ort_input
but error will be panic when feed this values into theSession
../scripts/run.sh: line 13: 12963 Segmentation fault: 11 RUST_BACKTRACE=full ./target/debug/edge-runtime "$@" start --main-service ./examples/main --event-worker ./examples/event-manager
What is the new behavior?
Following the ort api reference: The 'N' of elements 'T' must be equal to the Tensor's 'dims product'.
So we must prevent it by checking if the
Tensor
length reflects in itsdim shape