-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: implement lazy load for eszip entities #343
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
9c4b11b
to
7ca582e
Compare
Note: |
@@ -33,22 +35,25 @@ impl DenoCompileFileSystem { | |||
} | |||
} | |||
|
|||
fn copy_to_real_path(&self, oldpath: &Path, newpath: &Path) -> FsResult<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing this function? We could just create an async one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall that some of the functions it calls in its function body had their signatures changed to async, so I changed those functions to async due to contagious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I could probably make that synchronously again by spawning async functions in the blocking threads
64965f2
to
31472b8
Compare
8cd543a
to
5e8276e
Compare
031ab74
to
c4d1d21
Compare
…the service path and support lazy loading for the static files (1)
…ttern in the test scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Did some testing locally and common scenarios seems to work :)
🎉 This PR is included in version 1.56.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What kind of change does this PR introduce?
Enhancement
Description
This PR changes the way opaque data is stored in eszip and makes allow lazy-load for individual data stored in eszip.
Sample
Metrics (Observed lowest value in local)
Notes
It supports runtime migration for bundles created before this PR. However, performance will revert back to what it was before, so I recommend regenerating the bundle.