Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

fix: allow nullable role in User.fromJson() #108

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Conversation

Vinzent03
Copy link
Contributor

In response to today's issues (https://status.supabase.com/incidents/zmw9wwlwnj8g), it might be a good idea to not require role to be non-nullable if the actual type is nullable.

@Vinzent03
Copy link
Contributor Author

Should I increase the version number as well here?

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, great idea. And yes, let's bump the version number and do a release!

@dshukertjr dshukertjr merged commit 6243893 into main Dec 13, 2022
@dshukertjr dshukertjr deleted the fix/nullable-role branch December 13, 2022 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants