-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To 0.5 #65
To 0.5 #65
Conversation
To remove the possibility of them being used as FKs Fixes supabase#44
To reduce CPU usage, keep the check_worker_is_up function for debugging.
The index doesn't get used on the DELETE FROM net._http_response in worker.c anyway because `clock_timestamp()` forces a Seq Scan.
Their contents shouldn't survive a crash, and UNLOGGED makes the INSERTs/DELETEs faster and consume less CPU.
Btw |
Some issues with the 0.4 -> 0.5 upgrade script:
|
Edit: Nevermind, I managed to reproduce it on the dashboard, I'll just add CASCADE to the script.
Current queue doesn't have a FK Lines 42 to 43 in deed712
This was removed on 8538d83#diff-539e81249472b5ef91e28038ee011b645c8885f37ed6679e34d4483e23f4d390L46-R43 Already included on a previous script pg_net/sql/pg_net--0.2--0.3.sql Line 7 in deed712
How are you testing the upgrade script? I can't reproduce the error |
✅
Added IF EXISTS
These now work. |
I created a new supabase instance(has pg_net 0.2), enabled a webhook and did: alter extension pg_net update to '0.3';
alter extension pg_net update to '0.4';
alter extension pg_net update to '0.5'; -- had to manually download pg_net--0.4--0.5.sql to /var/lib/postgresql/extension And all of them ran successfully. Although I had to fix It would have been good to have pgtap testing for migrations but doesn't seem worth it for now(not sure what pgx will change). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing:
Small improvements to make pg_net a bit more stable.
Closes #61 and #44.
Also reducing unnecessary work done by pg_net to address cases where there is high amount of requests - ref(slack link)