Skip to content

Conversation

avallete
Copy link
Member

@avallete avallete commented Aug 29, 2025

What kind of change does this PR introduce?

  • Filtering on queries happen after the initial gathering happened over all the elements. This PR change it to include the filters (at least the schemaFilter) at the root of the query. Speeding introspections queries up for type generation as long as an includedSchema field is present.

  • Rework the queries so the retrieve also efficiently filter upstream queries

  • Tested this to also re-generate the types on postgrest-js repo, no diff showed up, which help ensure a bit more that there is no functional changes in the results of the introspection.

  • Tested over a "problematic" database with a lot of schemas that timeouted with types introspections, went from a ~22s running time to ~200ms to generate the types.

@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17399909026

Details

  • 394 of 419 (94.03%) changed or added relevant lines in 42 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 77.075%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/PostgresMetaFunctions.ts 13 14 92.86%
src/lib/PostgresMetaPublications.ts 7 8 87.5%
src/lib/sql/functions.sql.ts 19 20 95.0%
src/lib/helpers.ts 9 11 81.82%
src/lib/PostgresMetaForeignTables.ts 20 24 83.33%
src/lib/PostgresMetaTablePrivileges.ts 7 11 63.64%
src/lib/PostgresMetaViews.ts 20 24 83.33%
src/lib/PostgresMetaMaterializedViews.ts 16 24 66.67%
Totals Coverage Status
Change from base Build 16901428468: 0.9%
Covered Lines: 5302
Relevant Lines: 6777

💛 - Coveralls

@avallete avallete marked this pull request as ready for review September 1, 2025 12:17
@avallete avallete requested review from a team as code owners September 1, 2025 12:17
@avallete avallete requested a review from soedirgo September 2, 2025 09:56
@soedirgo soedirgo merged commit 28cd3e6 into master Sep 3, 2025
5 checks passed
@soedirgo soedirgo deleted the avallete/pgmeta-73-suboptimal-tables-query-schema-filter-happens-late branch September 3, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants