perf: suboptimal tables query schema filter happens late #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Filtering on queries happen after the initial gathering happened over all the elements. This PR change it to include the filters (at least the schemaFilter) at the root of the query. Speeding introspections queries up for type generation as long as an
includedSchema
field is present.Rework the queries so the
retrieve
also efficiently filter upstream queriesTested this to also re-generate the types on
postgrest-js
repo, no diff showed up, which help ensure a bit more that there is no functional changes in the results of the introspection.Tested over a "problematic" database with a lot of schemas that timeouted with types introspections, went from a ~22s running time to ~200ms to generate the types.