fix: change fetch polyfill #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 0.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Update: Apparently the bug doesn't exist when using Skypack, but I'll keep this change for now. |
|
Looks like they finally solved this @soedirgo developit/unfetch#109 I want to confirm that we'll stick with cross-fetch? If so, I will migrate gotrue-js too |
|
Yeah, I'm partial towards cross-fetch because of project health. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the current behavior?
There's some problems using postgrest-js from jspm, probably related to developit/unfetch#104 and developit/unfetch#109. The repo doesn't look too healthy, so I'm switching to cross-fetch for the fetch polyfill, which uses github/fetch under the hood.