Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

fix: realtime not emitting array value correctly #22

Merged
merged 2 commits into from
Aug 22, 2021
Merged

fix: realtime not emitting array value correctly #22

merged 2 commits into from
Aug 22, 2021

Conversation

dshukertjr
Copy link
Member

@dshukertjr dshukertjr commented Aug 21, 2021

What kind of change does this PR introduce?

Bug fix.

Closes #21
Related supabase/supabase-dart#44

What is the current behavior?

Parameters sent to toArray method was in wrong order, resulting in passing type as the stringValue and stringValue as the type.

What is the new behavior?

Changed toArray to take named parameters to prevent confusion and passing the correct parameters now.

Copy link
Contributor

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dshukertjr dshukertjr merged commit 4cedadf into supabase:main Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listening to realtime events on varchar[] column always returns ['archa'] and not the actual array content
2 participants