fix: set cookies for password recovery event #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
approved these changes
Jul 3, 2024
J0
force-pushed
the
fix-set-cookies-for-password-recovery-event
branch
from
7501201
to
d2d71c8
Compare
|
Thank you! |
2 tasks
hf
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2024-08-19) ### Features * update CI so it runs on release as well ([#33](#33)) ([4517996](4517996)) ### Bug Fixes * re-apply update CI so it runs on release as well ([#49](#49)) ([51d5a43](51d5a43)) * revert "update CI so it runs on release as well" ([#44](#44)) ([9d0e859](9d0e859)) * set cookies for password recovery event ([#32](#32)) ([7dc1837](7dc1837)) * set cookies when mfa challenge is verified ([#27](#27)) ([c217f53](c217f53)) * update conventional commits ci to use main instead of master ([#31](#31)) ([bebce89](bebce89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When resetting a user's password with an email template which has a URL defining the
typevalue asrecovery, and using theverifyOtpmethod to process the token_hash and type, the SSR server client'sonAuthStateChangefunction does not recognize thePASSWORD_RECOVERYevent that verifyOtp fires. This prevents the code here from running; resulting in the new session not being saved to cookies, and the user is not considered logged in.Fixes #21
What is the new behavior?
User is logged in.
Additional context
Replaces PR #24