Skip to content

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Nov 17, 2022

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Currently, we bubble up S3 error to the client when accessing a non-existing public object

What is the new behavior?

We will return 404

@coveralls
Copy link

coveralls commented Nov 17, 2022

Pull Request Test Coverage Report for Build 3489885068

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 86.774%

Totals Coverage Status
Change from base Build 3489221783: -0.008%
Covered Lines: 4581
Relevant Lines: 5266

💛 - Coveralls

@fenos fenos merged commit 9d5c09d into master Nov 17, 2022
@fenos fenos deleted the fix/handle-404-gracefully branch November 17, 2022 16:20
@github-actions
Copy link

🎉 This PR is included in version 0.24.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants