Skip to content

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Nov 24, 2022

What kind of change does this PR introduce?

Fixes

What is the current behavior?

  • render route is too generic
  • is not possible to transform images using a signed URL
  • downloading transformed image is not supported

What is the new behaviour?

  • renamed render route to be more explicit /render/image
  • support signed URL transformations
  • support download for transformed images
  • Improved error handling
  • renamed ENV variable DISABLE_IMAGE_TRANSFORMATION to ENABLE_IMAGE_TRANSFORMATION

@fenos fenos force-pushed the routes/renaming-render-prefix branch from 903167f to 119b617 Compare November 24, 2022 16:12
@fenos fenos force-pushed the routes/renaming-render-prefix branch from 119b617 to 3bfe601 Compare November 24, 2022 16:20
@coveralls
Copy link

coveralls commented Nov 24, 2022

Pull Request Test Coverage Report for Build 3542249578

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 65 of 133 (48.87%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 86.413%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http/routes/render/renderSignedImage.ts 51 76 67.11%
src/storage/backend/s3.ts 0 43 0.0%
Files with Coverage Reduction New Missed Lines %
src/storage/backend/s3.ts 1 42.62%
Totals Coverage Status
Change from base Build 3513880768: -0.4%
Covered Lines: 4657
Relevant Lines: 5379

💛 - Coveralls

@fenos fenos merged commit 163b507 into master Nov 24, 2022
@fenos fenos deleted the routes/renaming-render-prefix branch November 24, 2022 16:23
@github-actions
Copy link

🎉 This PR is included in version 0.24.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants