Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gotrue, supabase_flutter): Add identity linking and unlinking methods. #760

Merged
merged 18 commits into from Jan 2, 2024

Conversation

dshukertjr
Copy link
Member

@dshukertjr dshukertjr commented Dec 13, 2023

What kind of change does this PR introduce?

This PR brings one of the core auth launch announced at LWX.

Add a method to retrieve URL for manual linking OAuth providers, and adds a method to launch the URL obtained from Gotrue to supabase_flutter.

What is the current behavior?

Manual identity linking is not possible using supabase_flutter.

What is the new behavior?

Manual identity linking is now poissible.

@dshukertjr dshukertjr marked this pull request as ready for review December 20, 2023 08:18
@dshukertjr dshukertjr changed the title feat(gotrue, supabase_flutter): add identity linking methods to gotrue feat(gotrue, supabase_flutter): Add identity linking and unlinking methods. Dec 20, 2023
Copy link
Collaborator

@Vinzent03 Vinzent03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't to do with this pr specifically, but I think the url field from OAuthResponse can be String and not String?

@dshukertjr
Copy link
Member Author

@Vinzent03 Done!

@Vinzent03
Copy link
Collaborator

The tests are failing now.l, because of unnecessary !.

@dshukertjr
Copy link
Member Author

Thanks! Should've caught that one 😂

@dshukertjr dshukertjr merged commit 6c0c922 into main Jan 2, 2024
8 checks passed
@dshukertjr dshukertjr deleted the feat/identity-linking branch January 2, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants