New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gotrue, supabase_flutter): Add identity linking and unlinking methods. #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
changed the title
feat(gotrue, supabase_flutter): add identity linking methods to gotrue
feat(gotrue, supabase_flutter): Add identity linking and unlinking methods.
Dec 20, 2023
Vinzent03
reviewed
Dec 21, 2023
Vinzent03
requested changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hasn't to do with this pr specifically, but I think the url
field from OAuthResponse
can be String
and not String?
@Vinzent03 Done! |
The tests are failing now.l, because of unnecessary |
Thanks! Should've caught that one 😂 |
Vinzent03
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR brings one of the core auth launch announced at LWX.
Add a method to retrieve URL for manual linking OAuth providers, and adds a method to launch the URL obtained from Gotrue to supabase_flutter.
What is the current behavior?
Manual identity linking is not possible using supabase_flutter.
What is the new behavior?
Manual identity linking is now poissible.