Skip to content

Conversation

mandarini
Copy link
Contributor

@mandarini mandarini commented Sep 25, 2025

What kind of change does this PR introduce?

Change import. Goes together with this fix: supabase/storage-js#255

What is the current behavior?

Release breaks due to

error: [ERR_MODULE_NOT_FOUND] Cannot find module 'file:///home/runner/work/supabase-js/supabase-js/node_modules/@supabase/storage-js/dist/module/StorageClient' imported from 'file:///home/runner/work/supabase-js/supabase-js/src/lib/types.ts'
Did you mean to import with the ".js" extension?
    at file:///home/runner/work/supabase-js/supabase-js/src/lib/types.ts:4:38
[1:19:18 PM] [semantic-release] [@sebbo2002/semantic-release-jsr] › ℹ  jsr publish failed after 2593 ms:
[1:19:18 PM] [semantic-release] [@sebbo2002/semantic-release-jsr] › ✖  Error: Child process exited with: 1
    at ChildProcess.<anonymous> (/home/runner/work/supabase-js/supabase-js/node_modules/@sebbo2002/semantic-release-jsr/node_modules/jsr/dist/utils.js:221:24)
    at ChildProcess.emit (node:events:524:28)
    at ChildProcess._handle.onexit (node:internal/child_process:293:12)
[1:19:18 PM] [semantic-release] › ✖  Failed step "verifyConditions" of plugin "@sebbo2002/semantic-release-jsr"
[1:19:18 PM] [semantic-release] › ✖  An error occurred while running semantic-release: ExecError: Child process exited with: 1
    at ChildProcess.<anonymous> (/home/runner/work/supabase-js/supabase-js/node_modules/@sebbo2002/semantic-release-jsr/node_modules/jsr/dist/utils.js:221:24)
    at ChildProcess.emit (node:events:524:28)
    at ChildProcess._handle.onexit (node:internal/child_process:293:12) {
  code: 1,
  pluginName: '@sebbo2002/semantic-release-jsr'
}

What is the new behavior?

Does not break.

Additional context

First broke here: https://github.com/supabase/supabase-js/actions/runs/17734108834/job/50392646422 possibly due to package-lock.json changes.

@mandarini mandarini self-assigned this Sep 25, 2025
@mandarini mandarini marked this pull request as draft September 25, 2025 11:13
@coveralls
Copy link

coveralls commented Sep 25, 2025

Pull Request Test Coverage Report for Build 18006582351

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.455%

Totals Coverage Status
Change from base Build 17979936987: 0.0%
Covered Lines: 153
Relevant Lines: 155

💛 - Coveralls

@mandarini mandarini marked this pull request as ready for review September 25, 2025 11:52
@mandarini mandarini merged commit cd8173e into supabase:master Sep 25, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants