feat: add debug option for auth client #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5495303954
💛 - Coveralls |
|
@astoiccoder Can you please remove the package.json and package-lock.json files as they conflict and we'll merge this! |
|
@hf thanks a lot for having a look! Resolved the conflicts now |
hf
changed the title
hf
approved these changes
Jul 26, 2023
Pull Request Test Coverage Report for Build 5495303954Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5648782960Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 5648782960Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature to introduce the option to pass a debug flag down to gotrue client.
Bumps
gotrue-jsto v2.39.1.What is the current behavior?
Currently it is not possible to pass the debug flag to the authentication client.
The debug flag was recently introduced here and first released in v2.35.0.
What is the new behavior?
gotrue-jshas been bumped to v2.39.1 in order to make the debug flag option available inSupabaseAuthClientOptions.Introduce debug flag in
authsettings forSupabaseClientOptionsand pass it on to theSupabaseAuthClient.Additional context
This is my first try of a contribution, so please let me know if I did something wrong. Since this was faster implemented than described, I went straight to implementation instead of raising a discussion first.
If I should split the version bump in a separate PR please let me know as well.
Currently I have an issue with authentication in
supabase-jsclient and I believe having this debug option could help me understand the issue better.