fix: isolate PostgREST features from supabase-js #13
Conversation
Currently, some of postgrest-js's functionalities are implemented in supabase-js, like https://github.com/supabase/supabase-js/blob/33939998516e9325e207a63a8a3f10463e89aa41/src/index.js#L137 and https://github.com/supabase/supabase-js/blob/33939998516e9325e207a63a8a3f10463e89aa41/src/index.js#L177. This causes a mismatch of the implementations between the two, which caused supabase/postgrest-js#84. Since supabase-js is made to act like postgrest-js, we should implement PostgREST-related features solely on postgrest-js and expose that from supabase-js through prototypal inheritance.
|
Hey @soedirgo , just want to check on this with respect to the fork you've got in your personal account. Should I review this, or should I wait until you have finished what you're working on? |
|
I'm only working on postgrest-js at the moment, so it should be OK to review. I think what blocked me was some failing tests in #14 (probably an outdated Docker image). |
|
Forgot to mention, if this gets merged, things like filters/ |
|
OK we're going to hold off merging this until your signal Bobbie - I guess we will close this in favour of your postgrest-js changes |
|
👍 I also wanted to make some changes to this PR in light on the change on postgrest-js. I'll draft this for now and reopen once it's ready. |
|
Superseded by #50. |
Currently, some of postgrest-js's functionalities are implemented in supabase-js, like select and order. This causes a mismatch of the implementations between the two, which caused supabase/postgrest-js#84.
Since supabase-js is made to act like postgrest-js, we should implement PostgREST-related features solely on postgrest-js and expose that from supabase-js through prototypal inheritance.
I manually tested this on a new Supabase project, but there's some problem with the test suite so I couldn't get them to pass. Will address it in a separate PR.