Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add getLinkIdentityURL #342

Merged
merged 2 commits into from
Apr 16, 2024
Merged

feat(auth): add getLinkIdentityURL #342

merged 2 commits into from
Apr 16, 2024

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Apr 16, 2024

What kind of change does this PR introduce?

  • We had a _getURLForLinkIdentity experimental method for implementing manual identity linking.
  • This PR drops the experimental flag, and rename the method to getLinkIdentityURL to be aligned with Flutter.

@grdsdev grdsdev requested a review from dshukertjr April 16, 2024 13:25
@grdsdev grdsdev enabled auto-merge (squash) April 16, 2024 13:31
kangmingtay
kangmingtay approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@kangmingtay kangmingtay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@grdsdev grdsdev merged commit 202383d into main Apr 16, 2024
8 checks passed
@grdsdev grdsdev deleted the feat/link-identity branch April 16, 2024 13:31
@github-actions github-actions bot mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangmingtay kangmingtay kangmingtay approved these changes

@dshukertjr dshukertjr Awaiting requested review from dshukertjr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grdsdev @kangmingtay