Skip to content

Conversation

grdsdev
Copy link
Contributor

@grdsdev grdsdev commented Apr 19, 2024

What kind of change does this PR introduce?

  • Fixes some issues building the library in Linux/Windows.
  • Adds a Supported Platforms section to README making it clear the Linux/Windows aren't officially supported and may stop working on future versions.

See discussion in #337

@grdsdev grdsdev force-pushed the fix/linux-build branch 3 times, most recently from 871930a to 87ff515 Compare April 19, 2024 19:46
@grdsdev grdsdev requested a review from dshukertjr April 22, 2024 08:29
@grdsdev grdsdev marked this pull request as ready for review April 22, 2024 08:29
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There is one test that is failing, but everything else looks good.

@grdsdev grdsdev merged commit e62ad89 into main Apr 22, 2024
@grdsdev grdsdev deleted the fix/linux-build branch April 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants