Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): getSignedURLs method using wrong encoder #352

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix(storage): getSignedURLs method using wrong encoder #352

merged 1 commit into from
Apr 22, 2024

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Apr 22, 2024

What kind of change does this PR introduce?

Fixes #351

getSignedURLs was using the default encoder which encodes keys as snake_case by default. But this endpoint requires lowerCamelCase keys.

@grdsdev grdsdev enabled auto-merge (squash) April 22, 2024 12:08
@grdsdev grdsdev requested a review from dshukertjr April 22, 2024 12:08
@grdsdev grdsdev merged commit d1b0672 into main Apr 22, 2024
10 checks passed
@grdsdev grdsdev deleted the fix/getSignedURLs branch April 22, 2024 12:44
@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshukertjr dshukertjr dshukertjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createSignedURLs error in Supabase for Swift: body must have required property 'expiresIn'
2 participants
@grdsdev @dshukertjr