Skip to content

Conversation

chFlorian
Copy link

Issue

Issue Link

What kind of change does this PR introduce?

This PR introduces semantics updates for PostgrestFilterBuilder

What is the current behavior?

phfts(column: column, query: query, config: config)

What is the new behavior?

phrasetoFullTextSearch(column: String, query: String, config: String? = nil)

Additional context

The idea is to improve semantics by providing descriptive function names. These are implemented as an extension to PostgrestFilterBuilder, which allows to keep the existing function names (aka the mirrors of the JS library).

@satishbabariya satishbabariya self-assigned this Sep 6, 2021
@chFlorian
Copy link
Author

@satishbabariya should this be moved to supabase/postgrest-swift?

@grdsdev
Copy link
Contributor

grdsdev commented Sep 6, 2021

Hey @chFlorian thanks for the contribution, and yeah I think this change fits more in the supabase/postgrest-swift repo.

Other question, by following the convention, the case wouldn't be phraseToFullTextSearch with upper T after the phrase?

@chFlorian
Copy link
Author

Alright, then I will move this PR over to the other repo and delete it here once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants