Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix consistency for RLS in table editor #22119

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

joshenlim
Copy link
Member

@joshenlim joshenlim commented Mar 20, 2024

Resolves #22110

We have guard rails in place across the dashboard to prevent editing system schemas via the dashboard GUI - places with these guard rails have this notice as such:
image

We previously added an indication in the Table Editor to show the RLS status of the table, and it also served as a convenient way to enable RLS from there without having to go to the auth policies page. However, we didn't have the guardrails in place here, so this PR fixes that

@joshenlim joshenlim requested a review from a team as a code owner March 20, 2024 03:25
Copy link

supabase bot commented Mar 20, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Branching Preview Branches by Supabase.
Learn more about Supabase for Git ↗︎.

Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 4:46am
6 Ignored Deployments
Name Status Preview Comments Updated (UTC)
database-new ⬜️ Ignored (Inspect) Mar 20, 2024 4:46am
docs ⬜️ Ignored (Inspect) Mar 20, 2024 4:46am
studio ⬜️ Ignored (Inspect) Mar 20, 2024 4:46am
studio-self-hosted ⬜️ Ignored (Inspect) Mar 20, 2024 4:46am
ui-storybook ⬜️ Ignored (Inspect) Mar 20, 2024 4:46am
zone-www-dot-com ⬜️ Ignored (Inspect) Mar 20, 2024 4:46am

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshenlim joshenlim merged commit f370845 into master Mar 20, 2024
16 checks passed
@joshenlim joshenlim deleted the chore/fix-consistency-for-rls-in-table-editor branch March 20, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard allows enabling RLS on auth schema but not disabling
3 participants