feat: constrained extensions #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
force-pushed
the
constrained-exts
branch
4 times, most recently
from
4f4ade6
to
7d79673
Compare
This is only needed for extensions and we no longer are one.
steve-chavez
force-pushed
the
constrained-exts
branch
2 times, most recently
from
c305c9d
to
883a020
Compare
steve-chavez
force-pushed
the
constrained-exts
branch
from
883a020
to
d2353c1
Compare
steve-chavez
commented
Aug 31, 2023
| @@ -0,0 +1,231 @@ | |||
| #include "utils.h" | |||
|
|
|||
| #if PG13_GTE | |||
There was a problem hiding this comment.
I've made sure this feature only works for pg 13 onwards while not breaking pg 12 compat with other features. Check 883a020 commit message for more details.
It's considerable work to do this, we should consider dropping support for pg 12 later.
steve-chavez
commented
Aug 31, 2023
| case JCE_EXPECT_CPU: | ||
| case JCE_EXPECT_MEM: | ||
| case JCE_EXPECT_DISK: | ||
| parse->error_msg = "unexpected object for cpu, mem or disk, expected a value"; |
There was a problem hiding this comment.
I've tested these parse errors manually. Our test suite doesn't have a way to run with different configs for now.
olirice
approved these changes
Aug 31, 2023
|
awesome!! great work on the tests too 👀 |
steve-chavez
force-pushed
the
constrained-exts
branch
from
d2353c1
to
31432d2
Compare
Adds resource constraints for cpu, memory and disk for extensions. Compat with pg 12 is done by omitting constrainted extensions code using if macro directives checking the PostgreSQL version. Since all the tests are ran for all the pg versions, a variant comparison file for pg12 is used: https://www.postgresql.org/docs/current/regress-variant.html The variant test checks that all the extensions are created and that this only happens for pg 12. This way we ensure that the pg12 test output is not matched by accident for pg >= 13 and we get test failures if the constrained extensions code fails.
steve-chavez
force-pushed
the
constrained-exts
branch
from
31432d2
to
5032162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered documentation
Define a setting:
And extensions that don't comply the minimum resources will fail:
Tasks