fix: enable connection to custom database name other than 'postgres' #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w3b6x9
commented
Jan 13, 2024
w3b6x9
force-pushed
the
fix/custom-db-name
branch
6 times, most recently
from
2a36649
to
b161ed5
Compare
w3b6x9
changed the title
w3b6x9
force-pushed
the
fix/custom-db-name
branch
5 times, most recently
from
a208b85
to
a80901d
Compare
abc3
reviewed
Jan 18, 2024
abc3
reviewed
Jan 18, 2024
|
legend 🔥 |
w3b6x9
force-pushed
the
fix/custom-db-name
branch
from
ad73e27
to
e12ed3f
Compare
w3b6x9
force-pushed
the
fix/custom-db-name
branch
from
e12ed3f
to
0ee9134
Compare
abc3
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
I can only connect to the
postgresdatabase when connecting via Supavisor pooler.What is the new behavior?
I can connect to another database other than
postgresdatabase.Additional context
This addresses the GH issue Supavisor forces request to "postgres" database even when other database is specified #234.
While this solution enables connecting to other database, that's not
postgresdatabase, it presents other problems.Here are some things that should be tackled alongside this change for completeness:
postgresdatabase then it will default to other database. Whichever database a tenant connects to first will be the default one.2. Supavisor will continuously attempt to connect to a database even when that database doesn't exist. However, the client doesn't get the proper error feedback that database doesn't exist. See screen recording:Spun this out into its own issue: #257
Screen.Recording.2024-01-12.at.17.30.06.mov