Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: button color scheme #14

Closed
phamhieu opened this issue Jan 5, 2021 · 11 comments
Closed

feature: button color scheme #14

phamhieu opened this issue Jan 5, 2021 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@phamhieu
Copy link
Member

phamhieu commented Jan 5, 2021

Feature request

Is your feature request related to a problem? Please describe.

Primary color is too bright compare to the current Supabase button color. It's difficult to see the white label.

Screenshot 2021-01-05 at 5 37 03 PM

@MildTomato edits -
A couple of other issues -

  • Button to be less rounded

  • Add text-shadows

  • font inheritance not working

@phamhieu phamhieu added the enhancement New feature or request label Jan 5, 2021
@MildTomato MildTomato self-assigned this Jan 5, 2021
@MildTomato
Copy link
Contributor

We have a bit of a mismatch across all the websites - I'll fix it up

@kiwicopple
Copy link
Member

A couple of others

  • The button is more rounded
  • There is no dark-green text shadow

@MildTomato
Copy link
Contributor

Fixing this now

@MildTomato
Copy link
Contributor

We do have a few mismatch of colours in a few places.

in the auth home screen in /app we use green-600 on the large buttons, but in the button component we use green-500. the tailwind config doesn't actually contain our brand color of #3ECF8, although green-600 is close (ish).

I think @kiwicopple text shadow should fix how it looks though - so i'll test it out.

we should probably update the tailwind config in /app to use our brand palette (same as used by the marketing site, and ui lib), rather than the old green colors.

// ui and marketing site
brand: {
          50: '#82dab0',
          100: '#82dab0',
          200: '#69d3a0',
          300: '#50cb90',
          400: '#C5F1DD',
          500: '#9FE7C7',
          600: '#65D9A5',
          700: '#3ECF8E',
          800: '#38BC81',
          900: '#10633E',
 },
 // dashboard app
 green: {
          '100': '#c5f1dd',
          '200': '#c5f1dd',
          '300': '#9fe7c7',
          '400': '#65d9a5',
          '500': '#24b47e',
          '600': '#38bc81',
          '700': '#1c8656',
          '800': '#10633e',
          '900': '#10633e',
        }

MildTomato added a commit that referenced this issue Jan 6, 2021
…ed button sizes when inside a <Space> component. #14
@MildTomato
Copy link
Contributor

made some improvements - looks good with shadows.
i'll leave this issue open though for now.

@kiwicopple
Copy link
Member

Nice one - also:

image

left side of the button -> icon
vs
right side of the icon -> text

The space between these looks different yeah? Should they be even?

@MildTomato
Copy link
Contributor

MildTomato commented Jan 6, 2021

let's make a right icon option 👍 (also I want it for @joshenlim's chevron 😄 )
created issue #26

i think the alignment might be caused by feathericons taking some liberty with their margins - might not be the best icon pack to use.

Screenshot 2021-01-06 at 17 59 58
Screenshot 2021-01-06 at 17 59 10
Screenshot 2021-01-06 at 18 04 30

created issue #25

@MildTomato
Copy link
Contributor

Nice one - also:

image

left side of the button -> icon
vs
right side of the icon -> text

The space between these looks different yeah? Should they be even?

right icon support has been added in a previous release now 👍 @kiwicopple

@kiwicopple
Copy link
Member

legend, thanks Jonny!

i think the alignment might be caused by feathericons taking some liberty with their margins - might not be the best icon pack to use.

That's pretty annoying. Can we set the icon somehow to always be square, then center the icon within the space? That would create even margins on both sides right?

image

@MildTomato
Copy link
Contributor

That's pretty annoying. Can we set the icon somehow to always be square, then center the icon within the space? That would create even margins on both sides right?

oh yea, i was going to do that 🚀 great minds..

@MildTomato
Copy link
Contributor

closing this as outstanding remarks are in other issues
icon alignment - #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants