Skip to content

feat:[PAYM-2469] Delete superpay term #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

feat:[PAYM-2469] Delete superpay term #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3ed269
feat:[PAYM-2469] Delete superpay term
Feb 6, 2025
26ea030
feat:[PAYM-2469] Fix tests
Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/PaymentTerm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { PaymentMethod } from './PaymentMethod';

export type PaymentTerm =
| 'other'
| 'superpay'
| 'ach'
| 'comchek'
| 'on_delivery'
Expand All @@ -24,10 +23,8 @@ export type PaymentTerm =
| '45_days'
| '60_days';

// @deprecated – use `OTHER_PAYMENT_TERMS`
export const PAYMENT_TERMS: PaymentTerm[] = [
export const OTHER_PAYMENT_TERMS: PaymentTerm[] = [
'other',
'superpay',
'ach',
'comchek',
'cash_on_pickup',
Expand All @@ -44,7 +41,6 @@ export const PAYMENT_TERMS: PaymentTerm[] = [
'45_days',
'60_days',
];
export const OTHER_PAYMENT_TERMS = PAYMENT_TERMS;

export const SUPERPAY_TERMS: PaymentTerm[] = [
'1_3_days',
Expand Down Expand Up @@ -161,8 +157,6 @@ export function formatPaymentTerm(
return 'ACH';
case 'quick_pay':
return 'QuickPay';
case 'superpay':
return 'SuperPay';

case 'on_delivery':
return 'On Delivery';
Expand Down
5 changes: 0 additions & 5 deletions src/__tests__/PaymentTerm.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ it('formats known', () => {
"Other",
"Other",
],
Array [
"superpay",
"SuperPay",
"SuperPay",
],
Array [
"ach",
"ACH",
Expand Down
21 changes: 0 additions & 21 deletions src/__tests__/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ it('exports public api', () => {
],
"ALL_PAYMENT_TERMS": Array [
"other",
"superpay",
"ach",
"comchek",
"cash_on_pickup",
Expand Down Expand Up @@ -145,7 +144,6 @@ it('exports public api', () => {
],
"OTHER_PAYMENT_TERMS": Array [
"other",
"superpay",
"ach",
"comchek",
"cash_on_pickup",
Expand Down Expand Up @@ -178,25 +176,6 @@ it('exports public api', () => {
"zelle",
"other",
],
"PAYMENT_TERMS": Array [
"other",
"superpay",
"ach",
"comchek",
"cash_on_pickup",
"cash_on_delivery",
"quick_pay",
"check_on_delivery",
"check_on_pickup",
"5_days",
"7_days",
"10_days",
"15_days",
"20_days",
"30_days",
"45_days",
"60_days",
],
"SUPERPAY_PAYMENT_METHODS": Array [
"superpay",
],
Expand Down