Skip to content

Conversation

bensalilijames
Copy link
Collaborator

@bensalilijames bensalilijames commented Oct 26, 2016

Description

Similar to other SS cleanup projects: ES6 used and general tidyup. This also uses MongoDB as a backing store rather than a file system, which allows SuperScript to scale (on AWS Lambda etc).

Motivation and Context

Have a common ES6 basis across all SS projects for better readability and code quality in general, and allow SS to scale by having central fact database on a server, rather than distributed filesystem folders of facts (which would have to be sync'ed somehow).

How Has This Been Tested?

Run all existing unit tests with success.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Only breaking change is that sfacts.expand() is no longer exposed to the user. It was previously aliasing sfacts.create(), so this should be used instead.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bensalilijames bensalilijames force-pushed the master branch 2 times, most recently from c9a1f1c to fe0c3a5 Compare October 26, 2016 17:54
@bensalilijames bensalilijames force-pushed the master branch 6 times, most recently from 2085e56 to 3f64e7e Compare October 26, 2016 22:55
@coveralls
Copy link

coveralls commented Oct 28, 2016

Coverage Status

Changes Unknown when pulling 103dbd6 on benhjames:master into * on superscriptjs:master*.

@bensalilijames bensalilijames changed the base branch from master to v1.0.0 October 28, 2016 16:02
@bensalilijames bensalilijames merged commit 4313eb0 into superscriptjs:v1.0.0 Oct 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants