-
Notifications
You must be signed in to change notification settings - Fork 620
275: Update user's password #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why do you think such API would be better than 2 endpoints allowing to separately change user's credentials? How is that different from password reset? There are reasons why I chose to do two separate requests and token generation for password change. I don't know yours for the API design that you proposed at this moment, so please explain. |
Because this is not a password reset flow.. it's simply one of the CRUD operations we provide to the backend against the objects of this recipe.
What is password request validation?
My logic is simply to provide CRUD operation on the objects of this recipe. That's all. The actual password reset flow is different. Happy to discuss on a call. |
Then this PR provides simple CRUD without session removal logic. |
Summary of change
This exposes an endpoint:
PUT /recipe/user/credentials
accepting the following body:Related issues
Test Plan
tbd
Documentation changes
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)Changes to the version if neededInbuild.gradle
If there are new dependencies that have been added inbuild.gradle
, please make sure to add them inimplementationDependencies.json
.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.Remaining TODOs for this PR