fix: throw if a protected prop is passed to JWTDataAPI #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Apr 6, 2023
Comment on lines
62
to
65
| if (getVersionFromRequest(req).greaterThanOrEqualTo(SemVer.v2_21) && | ||
| Arrays.stream(protectedPropNames).anyMatch(userDataInJWT::has)) { | ||
| throw new ServletException(new BadRequestException("The user payload contains protected field")); | ||
| } |
There was a problem hiding this comment.
these checks should not happen here, instead, update updateSession to have this check, and create another updateSessionBeforeCDI2_21 without the check and mark that as deprecated
Comment on lines
91
to
94
|
|
||
| if (Arrays.stream(protectedPropNames).anyMatch(userDataInJWT::has)) { | ||
| throw new ServletException(new BadRequestException("The user payload contains protected field")); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (Arrays.stream(protectedPropNames).anyMatch(userDataInJWT::has)) { | |
| throw new ServletException(new BadRequestException("The user payload contains protected field")); | |
| } |
Comment on lines
73
to
77
| if (getVersionFromRequest(req).greaterThanOrEqualTo(SemVer.v2_21) && | ||
| userDataInJWT != null && | ||
| Arrays.stream(protectedPropNames).anyMatch(userDataInJWT::has)) { | ||
| throw new ServletException(new BadRequestException("The user payload contains protected field")); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (getVersionFromRequest(req).greaterThanOrEqualTo(SemVer.v2_21) && | |
| userDataInJWT != null && | |
| Arrays.stream(protectedPropNames).anyMatch(userDataInJWT::has)) { | |
| throw new ServletException(new BadRequestException("The user payload contains protected field")); | |
| } | |
rishabhpoddar
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.Remaining TODOs for this PR