Skip to content

Passwordless #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jan 14, 2022
Merged

Passwordless #27

merged 23 commits into from
Jan 14, 2022

Conversation

porcellus
Copy link
Collaborator

Summary of change

Adding interfaces necessary to implement the passwordless recipe

Related issues

Checklist for important updates

  • Changelog has been updated
  • Changes to the version if needed
    • In build.gradle
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

rishabhpoddar
rishabhpoddar suggested changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@rishabhpoddar rishabhpoddar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it seems good. However, I think the number of functions is rather too many? Let's discuss on a call

rishabhpoddar
rishabhpoddar suggested changes Nov 17, 2021
View reviewed changes
rishabhpoddar
rishabhpoddar suggested changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@rishabhpoddar rishabhpoddar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that you want to remove getDevice, getCodesOfDevice and getCodeByLinkCodeHash from the interface? I ask cause without those, we will have to use the trasaction versions of these functions which means that those will have a FOR UPDATE in them.

@porcellus porcellus mentioned this pull request Nov 17, 2021
Merged
rishabhpoddar
rishabhpoddar suggested changes Nov 18, 2021
View reviewed changes
rishabhpoddar
rishabhpoddar suggested changes Nov 24, 2021
View reviewed changes
@rishabhpoddar rishabhpoddar changed the base branch from 2.10 to 2.11 January 9, 2022 06:08
@rishabhpoddar rishabhpoddar merged commit 5983f8c into 2.11 Jan 14, 2022
@rishabhpoddar rishabhpoddar deleted the passwordless branch January 14, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rishabhpoddar rishabhpoddar rishabhpoddar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porcellus @rishabhpoddar