Skip to content

fix: Multitenant totp #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023
Merged

fix: Multitenant totp #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6500051
fix: removed unused throw
sattvikc Apr 11, 2023
0d00a02
fix: handling fk
sattvikc Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/io/supertokens/pluginInterface/multitenancy/TenantIdentifierWithStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ public UserRolesSQLStorage getUserRolesStorage() {
return (UserRolesSQLStorage) this.storage;
}

public TOTPSQLStorage getTOTPStorage()
throws TenantOrAppNotFoundException {
public TOTPSQLStorage getTOTPStorage() {
if (this.storage.getType() != STORAGE_TYPE.SQL) {
// we only support SQL for now
throw new UnsupportedOperationException("");
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/io/supertokens/pluginInterface/totp/TOTPStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import io.supertokens.pluginInterface.exceptions.StorageQueryException;
import io.supertokens.pluginInterface.multitenancy.AppIdentifier;
import io.supertokens.pluginInterface.multitenancy.TenantIdentifier;
import io.supertokens.pluginInterface.multitenancy.exceptions.TenantOrAppNotFoundException;
import io.supertokens.pluginInterface.nonAuthRecipe.NonAuthRecipeStorage;
import io.supertokens.pluginInterface.totp.exception.DeviceAlreadyExistsException;
import io.supertokens.pluginInterface.totp.exception.UnknownDeviceException;
Expand All @@ -12,7 +13,7 @@ public interface TOTPStorage extends NonAuthRecipeStorage {
* Create a new device and a new user if the user does not exist:
*/
void createDevice(AppIdentifier appIdentifier, TOTPDevice device)
throws StorageQueryException, DeviceAlreadyExistsException;
throws StorageQueryException, DeviceAlreadyExistsException, TenantOrAppNotFoundException;

/**
* Verify a user's device with the given name:
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/io/supertokens/pluginInterface/totp/sqlStorage/TOTPSQLStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import io.supertokens.pluginInterface.exceptions.StorageQueryException;
import io.supertokens.pluginInterface.multitenancy.AppIdentifier;
import io.supertokens.pluginInterface.multitenancy.TenantIdentifier;
import io.supertokens.pluginInterface.multitenancy.exceptions.TenantOrAppNotFoundException;
import io.supertokens.pluginInterface.sqlStorage.SQLStorage;
import io.supertokens.pluginInterface.sqlStorage.TransactionConnection;
import io.supertokens.pluginInterface.totp.TOTPDevice;
Expand Down Expand Up @@ -34,6 +35,7 @@ public TOTPUsedCode[] getAllUsedCodesDescOrder_Transaction(TransactionConnection
* Insert a used TOTP code for an existing user:
*/
void insertUsedCode_Transaction(TransactionConnection con, TenantIdentifier tenantIdentifier, TOTPUsedCode code)
throws StorageQueryException, TotpNotEnabledException, UsedCodeAlreadyExistsException;
throws StorageQueryException, TotpNotEnabledException, UsedCodeAlreadyExistsException,
TenantOrAppNotFoundException;

}