New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wiiuse library to 0.15.4, fixes support for newer Wiimotes on Linux #3626

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@qwertychouskie
Copy link
Contributor

qwertychouskie commented Nov 26, 2018

STK's Wiiuse had some modifications, but I tested and upstream seems to work fine, and fixes the -TR Wiimote.

@deveee

This comment has been minimized.

Copy link
Member

deveee commented Nov 26, 2018

Update is simple, but did you test it?

@qwertychouskie

This comment has been minimized.

Copy link
Contributor

qwertychouskie commented Nov 26, 2018

Yes, and it works quite nicely, though for some reason Travis doesn't like it. Also AppVeyor fails but there should be an update to Wiiuse to address this soon.

@deveee

This comment has been minimized.

Copy link
Member

deveee commented Nov 26, 2018

Good. Fix travis is doable, most important is testing with real devices. I'm not sure if someone else has wii remote too...

@qwertychouskie qwertychouskie changed the title Update Wiiuse library to 0.15.3, fixes support for newer Wiimotes on Linux Update Wiiuse library to 0.15.4, fixes support for newer Wiimotes on Linux Nov 28, 2018

@qwertychouskie

This comment has been minimized.

Copy link
Contributor

qwertychouskie commented Nov 28, 2018

Hmm. Both Travis and AppVeyor fail with not finding wiiuse.h, but compilation works fine on my system. @deveee Can you take a look and see why, and push a fix?

@deveee

This comment has been minimized.

Copy link
Member

deveee commented Nov 29, 2018

Previously source files were in lib/wiiuse, now there is a "src" directory. Changing
include_directories("${PROJECT_SOURCE_DIR}/lib/wiiuse/")
to
include_directories("${PROJECT_SOURCE_DIR}/lib/wiiuse/src")
in STK cmake file fixes compilation for me.

@qwertychouskie

This comment has been minimized.

Copy link
Contributor

qwertychouskie commented Nov 30, 2018

OK, ready for merging.

@qwertychouskie

This comment has been minimized.

Copy link
Contributor

qwertychouskie commented Dec 9, 2018

@deveee Any chance of getting this merged soon, since the compilation was fixed?

@deveee

This comment has been minimized.

Copy link
Member

deveee commented Dec 9, 2018

I think that it needs some testing by more people on different systems, but I can't do it myself.

@hiker hiker added this to the 0.10.0 milestone Dec 13, 2018

@MarioCMFlys

This comment has been minimized.

Copy link

MarioCMFlys commented Jan 3, 2019

Tested on Ubuntu-based Linux and works as expected

@hiker hiker merged commit 5031e7a into supertuxkart:master Jan 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hiker

This comment has been minimized.

Copy link
Member

hiker commented Jan 3, 2019

Thanks a lot for the patch, and for testing!!

@qwertychouskie qwertychouskie referenced this pull request Jan 8, 2019

Open

Update Wiiuse build #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment