Choices - The new item remains visible after disabling item addition …

…using the creator.onCollectionItemAllowOperations event fix #5521 (#5529)
surveyjs · May 27, 2024 · 68bef95 · 68bef95
1 parent 12018fb
commit 68bef95
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/survey-creator-core/src/components/item-value.ts b/packages/survey-creator-core/src/components/item-value.ts
@@ -43,7 +43,6 @@ export class ItemValueWrapperViewModel extends Base {
     for(let key in specificChoices) {
       this.registerOnPropertyChanged(key, specificChoices[key]);
     }
-    //this.registerOnPropertyChanged("selectAllItem", "hasSelectAll");
     if (this.isNew) {
       question.visibleChoicesChangedCallback = () => {
         this.updateNewItemValue();
@@ -69,7 +68,9 @@ export class ItemValueWrapperViewModel extends Base {
     if (this.allowItemOperations.allowAdd === undefined) {
       this.allowItemOperations.allowAdd = true;
     }
-
+    if(!this.allowItemOperations.allowAdd) {
+      this.updateIsNewVisibility();
+    }
     if (!this.creator.isCanModifyProperty(question, "choices")) {
       this.canTouchItems = false;
     }
@@ -217,6 +218,12 @@ export class ItemValueWrapperViewModel extends Base {
   }
   private updateIsNew(question: QuestionSelectBase, item: ItemValue) {
     this.isNew = !question.isItemInList(item) && !this.isAutoGeneratedItem(item);
+    this.updateIsNewVisibility();
+  }
+  private updateIsNewVisibility(): void {
+    if(this.isNew) {
+      this.item.setIsVisible(!(this.allowItemOperations?.allowAdd === false));
+    }
   }
 
   get allowRemove() {

diff --git a/packages/survey-creator-core/tests/components.tests.ts b/packages/survey-creator-core/tests/components.tests.ts
@@ -260,6 +260,7 @@ test("item value allowAdd on events", () => {
   expect(noneAdorner.allowAdd).toBeTruthy();
   expect(otherAdorner.allowAdd).toBeFalsy();
   expect(newAdorner.allowAdd).toBeFalsy();
+  expect(newAdorner.item.isVisible).toBeFalsy();
 });
 
 test("item value no pointer down on new or editable", (): any => {