Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The onDragStart and onDragEnd events do not have parameter descriptions in the docs #5478

Closed
RomanTsukanov opened this issue May 8, 2024 · 1 comment
Assignees
Milestone

Comments

@RomanTsukanov
Copy link
Contributor

RomanTsukanov commented May 8, 2024

The event parameters are described in the DragStartEndEvent interface. However, these description do not get to the docs:

https://surveyjs.io/survey-creator/documentation/api-reference/survey-creator#onDragStart
https://surveyjs.io/survey-creator/documentation/api-reference/survey-creator#onDragEnd

Most likely, it's because the events are declared without using this.addCreatorEvent. And this.addCreatorEvent isn't used because the sender parameter is not SurveyCreatorModel:

https://github.com/surveyjs/survey-creator/blob/master/packages/survey-creator-core/src/creator-base.ts#L1747

@RomanTsukanov
Copy link
Contributor Author

Fixed by #5528

@OlgaLarina OlgaLarina added this to the v1.11.3 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants