Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties to cell and column attributes to expose constructor arguments #84

Merged
merged 10 commits into from
Nov 19, 2024

Conversation

jonsagara
Copy link
Contributor

As discussed here, I added properties to attributes that control cells and columns:

  • CellFormatAttribute
  • CellStyleAttribute
  • CellValueConverterAttribute
  • CellValueTruncateAttribute
  • ColumnHeaderAttribute
  • ColumnOrderAttribute
  • ColumnWidthAttribute

For attributes that only had a single constructor, I made the property nullability match nullability of the parameters.

For attributes that have multiple constructors, I made the properties nullable.

I also added corresponding unit tests.

…at, if we need to add a second constructor in the future, we don't have to make a breaking API change.
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (bb12192) to head (80fe5b0).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   89.96%   90.00%   +0.03%     
==========================================
  Files         152      152              
  Lines        5450     5450              
  Branches     1020     1017       -3     
==========================================
+ Hits         4903     4905       +2     
  Misses        211      211              
+ Partials      336      334       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sveinungf
Copy link
Owner

Looks very good! Thanks!

@sveinungf sveinungf merged commit d302f75 into sveinungf:main Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants