-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add properties to cell and column attributes to expose constructor arguments #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pose the various constructor argument values. Started adding tests for the new properties.
sveinungf
requested changes
Nov 18, 2024
…at, if we need to add a second constructor in the future, we don't have to make a breaking API change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 89.96% 90.00% +0.03%
==========================================
Files 152 152
Lines 5450 5450
Branches 1020 1017 -3
==========================================
+ Hits 4903 4905 +2
Misses 211 211
+ Partials 336 334 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Looks very good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, I added properties to attributes that control cells and columns:
CellFormatAttribute
CellStyleAttribute
CellValueConverterAttribute
CellValueTruncateAttribute
ColumnHeaderAttribute
ColumnOrderAttribute
ColumnWidthAttribute
For attributes that only had a single constructor, I made the property nullability match nullability of the parameters.
For attributes that have multiple constructors, I made the properties nullable.
I also added corresponding unit tests.