Skip to content

feat(tooltips): add delay prop #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

joligoms
Copy link
Contributor

@joligoms joligoms commented Nov 18, 2023

Hello! 👋

I've just made a tiny change here, nothing much. I felt the need to specify the animation's delay in some cases.

Changes made:

  • Added a 'delay' prop to the tooltip component and action, defaulting to 200 milliseconds (ms).
  • Included the prop types for both the component and action.

Please let me know the reasons for not including this prop if you have any!

Nice plugin, btw!

@dysfunc dysfunc added Type: Feature A new feature or functionality Priority: Low Bug, issue, or pull request is a P3 labels Nov 18, 2023
@dysfunc
Copy link
Contributor

dysfunc commented Nov 18, 2023

@joligoms thanks for the contribution! I honestly don't know why I didn't expose this before 🤦🏻 Please update the readme with the prop, description and default values. Thanks again!

@joligoms
Copy link
Contributor Author

Oh yes, I forgot to do it, thanks for reminding me. I just pushed the README changes :)

@dysfunc dysfunc merged commit 3f9d1dc into svelte-plugins:main Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Bug, issue, or pull request is a P3 Type: Feature A new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants