-
-
Notifications
You must be signed in to change notification settings - Fork 59
chore: move paraglide demo into separate page #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 55d64fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
I think this is a fine enough fix for now, but it could actually be cool if all the demos could seamlessly come together into a single route |
Tests will be fixed by #150, we don't need to bother about them here |
trying this out locally: is it just me, or is the initial page after starting the dev server for the first time taking ages to load? |
Cannot confirm this, for me it's nearly instantaneous. |
weird, it's fast now for me too. before, if i cleared the |
I actually prefer this option. It feels more nicely organized |
Closes #132
Puts the paraglide demo into a
/paraglide-demo
route and makes the question for demo default to true.In order to avoid "demo-clashing" between different adders i also moved the lucia demo from
/demo
to/lucia-demo
. As we have seen yesterday multiple people opted to install all integrations at once. Both demos do not play well together. At least I think it does not appear to be super convincing and might cause problems in the future.Another option would be to use
/demo/lucia
and/demo/paraglide
, but I personally think that the option implemented right now feels more natural too me (i.e. having lucia in front of demo, and not behind).