Skip to content

Conversation

manuel3108
Copy link
Member

Closes #132

Puts the paraglide demo into a /paraglide-demo route and makes the question for demo default to true.

In order to avoid "demo-clashing" between different adders i also moved the lucia demo from /demo to /lucia-demo. As we have seen yesterday multiple people opted to install all integrations at once. Both demos do not play well together. At least I think it does not appear to be super convincing and might cause problems in the future.

Another option would be to use /demo/lucia and /demo/paraglide, but I personally think that the option implemented right now feels more natural too me (i.e. having lucia in front of demo, and not behind).

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 55d64fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@149

commit: 55d64fd

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 16, 2024

I think this is a fine enough fix for now, but it could actually be cool if all the demos could seamlessly come together into a single route /demo. It would act as a single point to showcase all of the integrations

@manuel3108
Copy link
Member Author

Tests will be fixed by #150, we don't need to bother about them here

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 16, 2024

trying this out locally: is it just me, or is the initial page after starting the dev server for the first time taking ages to load?

@manuel3108
Copy link
Member Author

Cannot confirm this, for me it's nearly instantaneous.

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 16, 2024

weird, it's fast now for me too. before, if i cleared the project.inlang/cache dir, it would take ages to redownload the cache (which i suspect was the reason for the long initial loads)

@benmccann
Copy link
Member

Another option would be to use /demo/lucia and /demo/paraglide,

I actually prefer this option. It feels more nicely organized

@benmccann benmccann merged commit f089256 into main Oct 16, 2024
5 checks passed
@benmccann benmccann deleted the chore/move-paraglide-demo branch October 16, 2024 18:16
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Put paraglide demo in separate page and default to true

3 participants