Skip to content

Conversation

manuel3108
Copy link
Member

Closes: #50

Copy link

pkg-pr-new bot commented Oct 6, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-tooling@66
pnpm add https://pkg.pr.new/sveltejs/cli/sv@66
pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/core@66

commit: f6907c8

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks like it's working. The only questions I have are:

  • do we want the variable names to match create-svelte and the typescript-eslint docs? When I ran this it has a ts variable in the eslint config whereas the others use tseslint as the variable name. The js variable was the other that was different
  • can we make it use tabs for indentation instead of spaces? (sorry if I've asked this before, but I can't remember if there's a reason)

@manuel3108
Copy link
Member Author

manuel3108 commented Oct 7, 2024

We need to think which thing we want to follow here. The eslint docs assume that we name the js variable as js (https://eslint.org/docs/latest/use/getting-started) and the ts-eslint assume we name the ts stuff tseslint. That would leave us with js and tseslint which seems confusing.

And since all of this is happening in a special eslint file, adding the eslint suffix seems redundant, so I would personally prefer to leave as-is

@benmccann
Copy link
Member

Okay, that makes sense to me. I'm fine with the simpler js/ts names

Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

@AdrianGonz97 AdrianGonz97 merged commit 2c48a41 into main Oct 8, 2024
5 checks passed
@AdrianGonz97 AdrianGonz97 deleted the chore/eslint-use-typescript-eslint-helper branch October 8, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy changes from typescript-eslint changes from kit repo

3 participants