Builder pattern for addon options

[jycouet]

Closes #179

---

It seems that clack team will also go in this direction one day.

[changeset-bot]

🦋 Changeset detected

Latest commit: bb624c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
sv	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@686

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@686

commit: bb624c4

[benmccann]

I'm not sure I'm in love with the name prepareAddonOptions. How about addonOptions().option().build() or newAddonOptions().add().build()?

[jycouet]

I'm not sure I'm in love with the name prepareAddonOptions. How about addonOptions().option().build() or newAddonOptions().add().build()?

What about:
defineAddonOptions().add().build() ?

[benmccann]

Works for me

[43081j]

this works so much better than the object-style definitions before

i think we'll do the same in clack eventually 😅

[manuel3108]

I.... don't understand Typescript. Why do we need to make it more complicated to make it actually work... (especially referring to the internal createOptionBuilder).

If you ignore the internals though, this is sick. It fixes the issue without changing anything major. Apart from the open comment, I think this should be good to go.

[jycouet]

If you ignore the internals though, this is sick. It fixes the issue without changing anything major. Apart from the open comment, I think this should be good to go.

Spent a few fun hours on this! héhé.
Last comment done now IMO