Skip to content

chore: update adders to svelte@5 syntax #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 11, 2024
Merged

chore: update adders to svelte@5 syntax #69

merged 12 commits into from
Oct 11, 2024

Conversation

manuel3108
Copy link
Member

Closes #51

@manuel3108 manuel3108 changed the title update tailwind adder chore: update adders to svelte@5 syntax Oct 8, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 8, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/ast-tooling@69

pnpm add https://pkg.pr.new/sveltejs/cli/sv@69

pnpm add https://pkg.pr.new/sveltejs/cli/@svelte-cli/core@69

commit: 925246a

manuel3108
manuel3108 commented Oct 8, 2024
View reviewed changes
Copy link
Member Author

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since i cannot dissaprove my own PR, as discussed we need to extract the change here into a generic method, so that our adders can work in v4 and v5

@benmccann benmccann mentioned this pull request Oct 9, 2024
Closed
benmccann
benmccann reviewed Oct 11, 2024
View reviewed changes
benmccann
benmccann reviewed Oct 11, 2024
View reviewed changes
benmccann
benmccann reviewed Oct 11, 2024
View reviewed changes
manuel3108 and others added 2 commits October 11, 2024 17:56
@manuel3108 @benmccann
Update packages/adders/common.ts
ab885e2 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@manuel3108 @benmccann
Update packages/adders/tailwindcss/index.ts
5e9a45f 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@benmccann benmccann merged commit 939cd1b into main Oct 11, 2024
5 checks passed
@benmccann benmccann deleted the chore/update-adders-to-svelte-5-syntax branch October 11, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Svelte 5 syntax

2 participants

@manuel3108 @benmccann