chore: remove Lucia from `lucia` #98

AdrianGonz97 · 2024-10-12T20:22:54Z

closes #68

Outstanding questions:

What do we call it?
It's effectively still 'Lucia', just without the library. We could call it 'Oslo', but it has less name recognition and I don't think that would be technically correct either. Oslo provides some of the auth utilities (mainly the encoding and crypto bits), but it doesn't touch sessions.

changeset-bot · 2024-10-12T20:22:57Z

⚠️ No Changeset found

Latest commit: da14504

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pkg-pr-new · 2024-10-12T20:23:39Z

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@98

commit: da14504

manuel3108

Starting the dev server gives me the following error, though i'm unable to locate what it thinks is wrong: I was currently testing on a JS project, if that helps

Details

4:14:18 PM [vite] Pre-transform error: Expected '{', got 'type'
4:14:19 PM [vite] Error when evaluating SSR module /src/lib/server/auth.js:
|- RollupError: Expected '{', got 'type'
at getRollupError (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:392:41)
at convertProgram (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1070:26)
at parseAstAsync (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1924:93)
at async ssrTransformScript (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52319:11)
at async loadAndTransform (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:51917:72)
at async instantiateModule (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52817:44)

4:14:19 PM [vite] Error when evaluating SSR module /src/hooks.server.js:
|- RollupError: Expected '{', got 'type'
at getRollupError (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:392:41)
at convertProgram (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1070:26)
at parseAstAsync (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1924:93)
at async ssrTransformScript (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52319:11)
at async loadAndTransform (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:51917:72)
at async instantiateModule (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52817:44)

Error [RollupError]: Expected '{', got 'type'
at getRollupError (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:392:41)
at convertProgram (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1070:26)
at parseAstAsync (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1924:93)
at async ssrTransformScript (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52319:11)
at async loadAndTransform (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:51917:72)
at async instantiateModule (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52817:44) {
code: 'PARSE_ERROR',
pos: 518
}
Error [RollupError]: Expected '{', got 'type'
at getRollupError (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:392:41)
at convertProgram (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1070:26)
at parseAstAsync (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/rollup@4.22.5/node_modules/rollup/dist/es/shared/parseAst.js:1924:93)
at async ssrTransformScript (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52319:11)
at async loadAndTransform (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:51917:72)
at async instantiateModule (file:///D:/dev/web/svelte-cli-temp/node_modules/.pnpm/vite@5.4.8_@types+node@22.7.5/node_modules/vite/dist/node/chunks/dep-CDnG8rE7.js:52817:44) {
code: 'PARSE_ERROR',
pos: 518
}

Additionally it generates this while running in a js project

// src\lib\server\db\schema.js
export type Session = typeof session.$inferSelect;
export type User = typeof user.$inferSelect;

packages/adders/lucia/index.ts

AdrianGonz97 · 2024-10-13T17:51:08Z

This is in a better state now. Opened for further reviews and can merge once ready

packages/adders/lucia/index.ts

benmccann · 2024-10-13T18:31:54Z

Perhaps we should move some of the logic into a session.ts to match the example repo, which I find to help with organization: https://github.com/lucia-auth/example-sveltekit-email-password-2fa/blob/7f9f22d48fb058e4085a11c52528e781c4bc70df/src/lib/server/session.ts

As far as name, I agree Oslo doesn't feel right. I think it would make sense in the short-term, but as we add more functionality like OAuth, etc. we'll start using more libraries and then it wouldn't fit anymore. I think we could probably just call it "Auth". It wouldn't make sense to have "Auth" under "Auth" with the current main screen, but I think we could tweak that. E.g. put it under "Additional functionality" and then it would be fine

AdrianGonz97 · 2024-10-13T22:03:11Z

hmmm, I don't know. I think there's still value in calling it "Lucia" even if lucia isn't a direct dependency anymore. We're still following their model and guidance.

I'd like to think of it as if I were to make a shadcn-svelte extension/integration. Sure, there's no shadcn-svelte dependency, but the parts being installed are still coming from the project. I certainly wouldn't call it bits-ui or styled-component-library.

benmccann · 2024-10-14T16:02:29Z

hmmm, I don't know. I think there's still value in calling it "Lucia" even if lucia isn't a direct dependency anymore. We're still following their model and guidance.

It's true that we are for now, but what if we want to diverge a bit? E.g. we may offer things that aren't in their guide, change how things are setup, etc.

benmccann · 2024-10-14T16:07:17Z

I wonder actually if we should just go ahead and setup https://svelte.dev/docs/kit/auth as a URL to point to. It kind of feels like a nice thing for us to own. Let me try prototyping that real quick and see what it would look like

manuel3108

All the generated +page.svelte and +page.server.js have two line breaks after the imports.

I have never seen a one liner for jsdoc comments (expect for @type) but it works, so I personally wouldn't bother.

/** @returns {string} */
function generateSessionToken() {

Apart from that everything seems to be working. Also tested the demo which ran just fine

packages/adders/lucia/index.ts

AdrianGonz97 added 11 commits October 11, 2024 15:21

update mode

096c9c0

partial auth impl

6c29fc4

add namespace import

7898a05

add test

b1f72e6

replace with a coarser approach for now

fc8b903

simplify

967548a

update hooks

44e1791

update demo

033b9a2

fix flags

6f489c6

update demo code

0267d7a

fix issues

e1c5708

go away

0fe5503

manuel3108 requested changes Oct 13, 2024

View reviewed changes

packages/adders/lucia/index.ts Outdated Show resolved Hide resolved

AdrianGonz97 added 4 commits October 13, 2024 13:09

dont export type when in js mode

5156e8c

fix jsdoc comments

7588d41

Merge branch 'main' into chore/update-lucia

b6b6ec8

add individual functions for better compatibility

5664544

Merge branch 'main' into chore/update-lucia

ba87f3e

benmccann reviewed Oct 13, 2024

View reviewed changes

packages/adders/lucia/index.ts Outdated Show resolved Hide resolved

update docs

6d53cda

AdrianGonz97 mentioned this pull request Oct 14, 2024

feat: improved homescreen for adding or creating projects #112

Merged

manuel3108 approved these changes Oct 14, 2024

View reviewed changes

packages/adders/lucia/index.ts Outdated Show resolved Hide resolved

fix spacing

42e24a7

AdrianGonz97 added 3 commits October 14, 2024 12:50

Merge branch 'main' into chore/update-lucia

f5e4729

update tests

72d37c1

Merge branch 'main' into chore/update-lucia

da14504

AdrianGonz97 merged commit e1c31d7 into main Oct 14, 2024
5 checks passed

AdrianGonz97 deleted the chore/update-lucia branch October 14, 2024 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: remove Lucia from `lucia` #98

chore: remove Lucia from `lucia` #98

Uh oh!

AdrianGonz97 commented Oct 12, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 12, 2024 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Oct 12, 2024 •

edited

Loading

Uh oh!

manuel3108 left a comment

Uh oh!

Uh oh!

AdrianGonz97 commented Oct 13, 2024

Uh oh!

Uh oh!

benmccann commented Oct 13, 2024

Uh oh!

AdrianGonz97 commented Oct 13, 2024

Uh oh!

benmccann commented Oct 14, 2024

Uh oh!

benmccann commented Oct 14, 2024

Uh oh!

manuel3108 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

chore: remove Lucia from lucia #98

chore: remove Lucia from lucia #98

Uh oh!

Conversation

AdrianGonz97 commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

pkg-pr-new bot commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manuel3108 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AdrianGonz97 commented Oct 13, 2024

Uh oh!

Uh oh!

benmccann commented Oct 13, 2024

Uh oh!

AdrianGonz97 commented Oct 13, 2024

Uh oh!

benmccann commented Oct 14, 2024

Uh oh!

benmccann commented Oct 14, 2024

Uh oh!

manuel3108 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore: remove Lucia from `lucia` #98

chore: remove Lucia from `lucia` #98

AdrianGonz97 commented Oct 12, 2024 •

edited

Loading

changeset-bot bot commented Oct 12, 2024 •

edited

Loading

pkg-pr-new bot commented Oct 12, 2024 •

edited

Loading