fix: create separate cache entries for non-exported queries #14499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54444c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
reviewed
Sep 22, 2025
teemingc
reviewed
Sep 22, 2025
|
|
||
| if (cache === undefined) { | ||
| cache = {}; | ||
| (state.remote_data ??= new Map()).set(info, cache); |
There was a problem hiding this comment.
Should we use a WeakMap here so that the info object key can be garbage collected?
There was a problem hiding this comment.
The whole thing will be garbage collected after state becomes obsolete, so I don't think we need it / should do it.
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
dummdidumm
reviewed
Sep 22, 2025
dummdidumm
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries are cached on the server per-request — that is, calling
myQuery()multiple times will only invoke the function once.At present, the cache key is a combination of the query
idand the stringified argument (if there is one), but this doesn't work if the query doesn't have anid, because it isn't exported from a.remote.tsfile. This PR fixes it.Non-exported queries are probably somewhat rare, but this is useful for things like an
isAuthenticated()query that's used in multiple places.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits