Skip to content

Conversation

teemingc
Copy link
Member

@teemingc teemingc commented Oct 3, 2025

Follow up to #12132

The %sveltekit.version% string is only available in app.html, not error.html so it should be moved under it in the docs.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Oct 3, 2025

⚠️ No Changeset found

Latest commit: d5785d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@teemingc teemingc added the documentation Improvements or additions to documentation label Oct 3, 2025
@svelte-docs-bot
Copy link

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah whoops. though i have to wonder if version should be available in error.html too. separate question though

@Rich-Harris Rich-Harris merged commit 81ebc81 into main Oct 3, 2025
22 checks passed
@Rich-Harris Rich-Harris deleted the teemingc-patch-1 branch October 3, 2025 12:54
@teemingc
Copy link
Member Author

teemingc commented Oct 5, 2025

ah whoops. though i have to wonder if version should be available in error.html too. separate question though

Probably same for the other interpolated strings. There was an issue asking to have access to assets so that they can link the same stylesheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants