fix: granular updates of field.value()
#14621
Merged
+106
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes a TODO, and insodoing fixes an actual bug — if you edit a form that contains a select, the
value
getter will re-run (becauseinput
has changed) and nuke the select because the model value is typicallyundefined
to start with.Unfortunately it doesn't quite work, because an effect doesn't depend on the$derived
values that were created inside it. So when you do{field.value()}
, you're creating a derived and then immediately (trying to) depend on it. I'm not immediately sure what footwork would be required to work around that, or if it indicates that it should be possible for an effect to depend on a derived it created. So I'm leaving this in draft for now.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits