-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] More powerful and configurable rendering options #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b64790 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
force-pushed
the
scriptable-opts
branch
2 times, most recently
from
July 25, 2021 14:05
327d007
to
a25fec9
Compare
benmccann
force-pushed
the
scriptable-opts
branch
9 times, most recently
from
July 25, 2021 22:33
3cbff8e
to
4252e16
Compare
5 tasks
benmccann
force-pushed
the
scriptable-opts
branch
from
July 26, 2021 16:09
4252e16
to
1068014
Compare
5 tasks
benmccann
force-pushed
the
scriptable-opts
branch
from
July 27, 2021 20:07
1068014
to
9b64790
Compare
sidharthv96
added a commit
to sidharthv96/kit
that referenced
this pull request
Jul 31, 2021
…ePath * 'master' of https://github.com/sveltejs/kit: (85 commits) [chore] minor simplification of `parse_body` (sveltejs#2043) Version Packages (next) (sveltejs#2026) [chore] deduplicate config types (sveltejs#2030) [chore] remove invalid css declaration (sveltejs#2038) [fix] correctly pass Vite options in preview mode (sveltejs#2036) [feat] Ignore adapter build files (sveltejs#1924) [chore] Upgrade Rollup Don't check external links on prerender (sveltejs#1679) Version Packages (next) (sveltejs#2017) [chore] convert remaining type aliases (sveltejs#2018) [feat] explicitly set compilerOptions.hydratable to config.kit.hydrate (sveltejs#2024) [feat] More powerful and configurable rendering options (sveltejs#2008) [chore] typecheck example (sveltejs#2019) Change config `prerender.force` to `prerender.onError` (sveltejs#2007) [chore] prefer interfaces to types (sveltejs#2010) [docs] minor wording improvement in migration guide (sveltejs#2006) [chore] test debugging improvements [docs] fix typo (sveltejs#2003) [chore] use @ts-expect-error instead of @ts-ignore (sveltejs#1999) Version Packages (next) (sveltejs#1996) ...
This was referenced Jul 31, 2021
Closed
benmccann
pushed a commit
that referenced
this pull request
Aug 1, 2021
This was referenced May 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows rendering options to be functions, so that you can do dynamic rendering, true-er SPA mode, and other cool stuff.
Closes #1650 - the highly requested "true-er spa mode"
I think it also closes #1942 - considering rendering options on error pages as requested by @GrygrFlzr though I didn't test that yet
Maybe closes #933 ?
TO NOTE:
function
which either reads the page-level option or request path. For now I just want to get the functionality implemented and then we can discuss defaults as a possible follow up