Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] mention vite-plugin-iso-import #2106

Merged
merged 4 commits into from
Aug 7, 2021
Merged

[docs] mention vite-plugin-iso-import #2106

merged 4 commits into from
Aug 7, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 5, 2021

Mention vite-plugin-iso-import in "How do I use a client-side only library that depends on document or window?" FAQ section. It could be useful as an alternative to the usual dynamic import dance and sveltejs/svelte#6372.

Currently, there's an issue with getting the import suffix intellisense to work with Svelte files, but it can be worked around with manual ambient type declarations.

Relies on #2112

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2021

⚠️ No Changeset found

Latest commit: 564c3f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants