-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
FIX: Separate playwrite templates for js vs ts #4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Playwrite file when building with typescript requires the playwrite.config file to have extension .ts
|
Thanks. If we're going to do this, we may as well just automatically install the |
I don't think this is resolved. When I create a new SvelteKit project ( Are these changes not released yet, perhaps? |
Yeah, the latest release of "create-svelte" was: |
contributes to #4478
As noted on #4478. We still need to wait for playwright to release the current
@playwright/test@next
version.Summary
Playwright file when building with typescript requires the
playwright.config
file to have extension.ts
.This PR adds replaces the single
+playwright
folder with 2 folders+playwright+typescript
and+playwright-typescript
, where the+typescript
file has itsplaywright.config
file with extension.ts
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
I have manually tested by doing:
cd packages/create-svelte node bin.js
Then following the prompts to make a app.
playwright.config.js
in the created app directoryplaywright.config.ts
in the created app directoryI also ran the actual test suite in each of the created folders:
npm install npm run test
For the typescript + playwright, I had to do the extra step get the next version of playwright:
npm install @playwright/test@next npm install npm run test
There are no tests in the
packages/create-svelte
currently.I'm happy to look into adding tests to ensure all the required files are created depending on the users input?...
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0