(chore) bump lsp #717
Merged
(chore) bump lsp #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump to new language server protocol version 3.16 with corresponding types. Also bump vscode-languageserver/languageclient. Caveat: Range/Position is now checked - all lines/columns must be 0 <= X <= MAX_INT, which means we cannot use Range.create on all occasions anymore. We need the temporary creation of invalid positions/ranges to deal with them later case-by-case ### BREAKING CHANGE vscode extension now requires a minimum vscode version of 1.52.0
jasonlyu123
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#715
Bump to new language server protocol version 3.16 with corresponding types. Also bump vscode-languageserver/languageclient.
Caveat: Range/Position is now checked - all lines/columns must be 0 <= X <= MAX_INT, which means we cannot use Range.create on all occasions anymore. We need the temporary creation of invalid positions/ranges to deal with them later case-by-case
BREAKING CHANGE
vscode extension now requires a minimum vscode version of 1.52.0
Notes
getEditsForFileRename-thing we currently have setup "by hand", there's a workspace_didRenameFiles command now. Update: I player around with it and I don't think it suits our needs:willRenameFilesis done before the rename operation, and computing all update-locations might take too long, so that's bad UX.didRenameFilesis a notification, not a request, so we cannot send something back.