Add accessors autocomplete #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
March 18, 2021 18:02
If the component option `accessors` is present / present and set to `true`, add getters and setters to the generated Svelte2TsxComponent class for each exported `let` prop. This way we get autocomplete / intellisense for accessors.
turns out we don't even need it, setter parameter type can be inferred via the corresponding getter, which is also always generated for an accessor.
Remove linebreak (was breaking existing tests).
5 new 'uses-accessors' tests / 217 tests (all passing)
113 / 217 tests (all passing)
- setters with brackets - `export const bar` don't create setters All 217 test are passing.
dummdidumm
reviewed
Mar 19, 2021
|
Thanks for the PR! I'll deal with the lint/failing tests in a separate PR so we can get this in for today's release |
I'm happy I could contribute! 😁 Keep up the great work! 👍🚀 + Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autocompletion for accessors.