Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

Revert "[fix] load images in Part 1 / Lifecycle / onMount excercise" #188

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Revert "[fix] load images in Part 1 / Lifecycle / onMount excercise" #188

merged 1 commit into from
Jan 23, 2023

Conversation

Rich-Harris
Copy link
Member

Reverts #174

@vercel
Copy link

vercel bot commented Jan 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 5:08PM (UTC)

dummdidumm
dummdidumm approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that this didn't work as expected (images still not loading), weird that it worked for according to the screenshot in the PR

@dummdidumm dummdidumm merged commit 6333fd7 into main Jan 23, 2023
@dummdidumm dummdidumm deleted the revert-174-main branch January 23, 2023 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@dummdidumm dummdidumm dummdidumm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @dummdidumm